Update of sr #1640 (project savane):
Status: Done => Need Info
Open/Closed: Closed => Open
Summary: SVN commits doesn't annotate items (correct) => SVN
commits doesn't annotate items correct if root_as_url_component = 0
_______________________________________________________
Follow-up Comment #5:
I have found this error too.
I'm using the option 'root_as_url_component = 0' in my viewcvs.conf file.
That means that my revision pages (that are linked to) look like:
http://svn.savannah.ugent.be/?root=testproject&rev=13&view=rev
The link the latest savane produces is:
http://svn.savannah.ugent.be/?root=testproject?rev=13&view=rev
It puts an ? before rev instead of a &.
In the code I found:
$out .= '<p>(<a
href="'.$svn_link.'?rev='.$entry['revision'].'&view=rev">'.sprintf(_("Browse
SVN revision %s"), $entry['revision']).'</a>)</p>';
So changing it to:
$out .= '<p>(<a
href="'.$svn_link.'&rev='.$entry['revision'].'&view=rev">'.sprintf(_("Browse
SVN revision %s"), $entry['revision']).'</a>)</p>';
fixes it.
The underlying problem is (I think) that savane assumes that all links to the
viewcvs front end contain the project name as a directory. For example:
http://svn.gna.org/viewcvs/savane/?rev=6443&view=rev
In my case that doesn't work.
We should/could check $svn_link. If there is already an ? in that string we
need to use an &, if it doesn't we should use an &. If this is ok I can
commit a fix like that to the trunk.
_______________________________________________________
Reply to this item at:
<http://gna.org/support/?1640>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Savane-doc-dev mailing list
[email protected]
https://mail.gna.org/listinfo/savane-doc-dev
