Review: Needs Fixing code review, no test Hello,
Thanks for the port of the module. Some comments below: Please use explicit relative import. line 166: +from openerp import pooler does not seems to be used Line 206 :+ except Exception, e: "as e" would be nicer. Also it may be useful to log the exception pgerror and/or pgcode You should put your authorship on automatic_workflow_job.py too. Not in the diff: I would validate in the _prepare_write_off function the way that the write off type is determined with a functional guy. I would not use: if not hasattr(ids, '__iter__') but if not isinstance(ids, (list, tuple)) In stock.py there is a #TODO reimplement me. Is it still of actuality? It will be nice to add a bit of documentation on the "sale.workflow.process" model. Keep up the good job. Regards Nicolas -- https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0-sale-workflow/+merge/155920 Your team extra-addons-commiter is subscribed to branch lp:~extra-addons-commiter/e-commerce-addons/7.0-sale-method. -- Mailing list: https://launchpad.net/~savoirfairelinux-openerp Post to : [email protected] Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp More help : https://help.launchpad.net/ListHelp
