Review: Needs Fixing

Hi Nishant,

Thanks for fixing the conflicts.

On your MP you made several modification in the way the code were indented and 
your modifications caused a PEP8 regression. Now the code is less pep8 
compliant than it was before. 

You changed the name of our company. It is Savoir-faire Linux, not 
Savoirfaire-Linux. (#11, #70, ...).

Replace orm by osv is a regression. The V7 way is orm.Model and 
orm.TransientModel. (#107, #138, ...)

That's all for now.

Regards.



-- 
https://code.launchpad.net/~serpentcs/openerp-isp/serpentcs_openerp-isp_7.0/+merge/190563
Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:openerp-isp.

-- 
Mailing list: https://launchpad.net/~savoirfairelinux-openerp
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp
More help   : https://help.launchpad.net/ListHelp

Reply via email to