Review: Needs Fixing code review, no tests Please remove executable right on those files (chmod -x):
base_external_dbsource/base_external_dbsource_demo.xml base_external_dbsource/__init__.py base_external_dbsource/security/ir.model.access.csv base_external_dbsource/test/dbsource_connect.yml import_odbc/import_odbc_demo.xml import_odbc/__init__.py import_odbc/security/ir.model.access.csv base_external_dbsource.py|33 col 1| F401 'pymssql' imported but unused base_external_dbsource.py|40 col 1| F811 redefinition of unused 'sqlalchemy' from line 32 base_external_dbsource.py|41 col 1| F401 'MySQLdb' imported but unused base_external_dbsource.py|65 col 1| F811 redefinition of unused 'sqlalchemy' from line 40 base_external_dbsource.py|166 col 1| F821 undefined name 'osv' base_external_dbsource.py|177 col 1| F821 undefined name 'osv' Use orm.execpt_orm instead And at least split the l.43 in import_odbc/import_odbc Cheers -- https://code.launchpad.net/~openerp-community/server-env-tools/7.0-modules-from-openobject-extension/+merge/183539 Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~openerp-community/server-env-tools/7.0-modules-from-openobject-extension. -- Mailing list: https://launchpad.net/~savoirfairelinux-openerp Post to : [email protected] Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp More help : https://help.launchpad.net/ListHelp
