Review: Needs Fixing code review, no test l.484, 809: what are you doing here? You have two different (and redundant checks) here. The result will always be "firstname lastname" because of l.484. However you check on l.486 which suggests you want to be able to support having either or. Either way l.485 is redundant.
l.804 why are you suddenly using CamelCase? -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions_firstname_lastname/+merge/199965 Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions. -- Mailing list: https://launchpad.net/~savoirfairelinux-openerp Post to : [email protected] Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp More help : https://help.launchpad.net/ListHelp
