Review: Needs Fixing Hi, David,
Seeing the code, I think you can follow better coding conventions to allow minimal changes on future versions: - On _prepare_inv_line method, you should call super method, and extend returned dictionary instead of overriding full method. - On the view definition, it's better to use <field name="xxx" position="yyy"> instead of xpath expression. Regards. -- https://code.launchpad.net/~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin/+merge/198321 Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_purchase_origin. -- Mailing list: https://launchpad.net/~savoirfairelinux-openerp Post to : [email protected] Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp More help : https://help.launchpad.net/ListHelp
