Review: Needs Fixing code review, no test l.9 for readability's sake, can you put ')' on a different line like it is done at l.26 l.181 seems to be a pointless line, if you're trying to hide it, use the <delete model="..." id="..." /> tag l.229 seems to be a pointless line, if you're trying to hide it, use the <delete model="..." id="..." /> tag l.367 no need to have base as a dependency l.436 no point in having a summary that is a cut and paste of the title, go for something along the lines of "Add ___ to __" l.506 this is python code, so keep it PEP8 (spaces after commas) -- https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/improvement_after_integration_new_partner_firstname/+merge/203350 Your team Savoir-faire Linux' OpenERP is subscribed to branch lp:~savoirfairelinux-openerp/partner-contact-management/base_contact_by_functions.
-- Mailing list: https://launchpad.net/~savoirfairelinux-openerp Post to : [email protected] Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp More help : https://help.launchpad.net/ListHelp
