Review: Needs Fixing code review, no tests

Hi Mathieu,

Thanks for your contribution.

Here's my review:

l.172 Please use orm instead of osv.
l.175 osv.Model -> orm.Model
l.192 It's not a good idea to override a view's external id. Please pick 
another name for the id. 
-- 
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_category_description/+merge/212507
Your team Savoir-faire Linux' OpenERP is subscribed to branch 
lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description.

-- 
Mailing list: https://launchpad.net/~savoirfairelinux-openerp
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~savoirfairelinux-openerp
More help   : https://help.launchpad.net/ListHelp

Reply via email to