Hi,

Romain Beauxis wrote:
I've greped for Printf.printf, and found some use that are legal, such as in lang.ml, main.ml and dynliq.ml, and some that do not seem..

I've written quick and dirty patch to convert them to log#f, but perhaps you'd like to have it another way ?

Yes, I would like you to leave it the way it is.

All the printf you changed are debug messages which are printed only if a debug parameter is set to true. The only exception is vumeter which should definitely use printf. For debugging purposes it's more convenient to have debugging messages not mixed with other logs and that's why printfs are nice.

Cheers,

Samuel.

Répondre à