#98: request.create() crashes if audio=false or absent
-------------------------+--------------------------------------------------
Reporter: GraveR | Owner: admin
Type: Bugs | Status: new
Priority: 1 | Milestone:
Component: Liquidsoap | Version: 0.3.6+svn
Resolution: | Keywords:
Mac: 1 | Other: 1
Freebsd: 1 | Linux: 1
-------------------------+--------------------------------------------------
Comment (by mrpingouin):
Hey. I found out by myself. Not a bug, but rather a rough feature.
The problem is that you pass a non-audio request to a request source, that
expects audio requests. Then the source tries to get the decoder for that
request, which fails unexpectedly. One may expect some check leading to a
nicer error, but except for that, this error makes sense. A dynamic
request source is not a playlist source.
By the way, thanks for pointing out the default audio=false, which I
changed to true now.
I'll leave the ticket open while we discuss about possible enhancements.
We could silently ignore non-audio requests, with a log message. Or plan
for a change in the type system, distinguishing both kind of requests.
--
Ticket URL: <http://savonet.rastageeks.org/ticket/98#comment:3>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
