[ 
http://dev.sourcefabric.org/browse/LS-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Beauxis reopened LS-173:
-------------------------------


Yep, you're right, I closed to quickly.. Reading select POSIX's specs from 
there:
  http://www.opengroup.org/onlinepubs/000095399/functions/select.html
It seems that the only error worth catching is EINTR. The error means that a 
signal interrupted select. Catching the error and restarting select should not 
create an infinite loop nor require any processing of the values passed to 
select so it seems fine to me.
Should I patch and close ?

> EAGAIN
> ------
>
>                 Key: LS-173
>                 URL: http://dev.sourcefabric.org/browse/LS-173
>             Project: Liquidsoap
>          Issue Type: New Feature
>          Components: Liquidsoap
>            Reporter: David Baelde
>            Assignee: Romain Beauxis
>            Priority: Blocker
>             Fix For: 1.0
>
>
> Just a minor thing to remember and address one day...
> I was listening to a stream via input.http and got disconnected because of 
> network lag (I had a big download next at the same time). At each 
> disconnection I obtained the following:
> {{{
> 2008/08/13 17:49:50 [stream.vorbis:2] Read error Unix.Unix_error(2, "read", 
> "")
> }}}
> My first thought was that we should make common errors more user-friendly, 
> i.e. put an explaination instead of the exception directly. My second thought 
> is that maybe we shouldn't even see that one, since it's actually EAGAIN: 
> does it come from a place where we improperly use Unix.read? By the way, this 
> error is followed by an End_of_file each time.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à