[ 
http://dev.sourcefabric.org/browse/LS-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15648#action_15648
 ] 

David Baelde commented on LS-501:
---------------------------------

Good catch concerning video_text.ml! It's also a good idea to install a 
protection against such problems, I should have thought about that last time I 
hacked one by hand to debug...

The position of the allow_lazy_config_eval in main.ml isn't so strong: it only 
protects against the forcing of the lazy values done before command-line 
parsing. But that's enough for bugs such as the one you spotted, where the 
value is used as the default for some operator's parameter. And I don't see a 
better solution anyway... it seems impossible.

Minor remark: I'd prefer a allow_lazy_config_eval of type unit -> unit, to 
signify that once it's been allowed it doesn't make sense to disallow it.

Also there's a typo: "before the user gets a chance to override" without an 
"s", in frame.ml and mli.

> Video size evaluated too early
> ------------------------------
>
>                 Key: LS-501
>                 URL: http://dev.sourcefabric.org/browse/LS-501
>             Project: Liquidsoap
>          Issue Type: Bug
>    Affects Versions: 1.0
>            Reporter: Romain Beauxis
>            Assignee: Romain Beauxis
>            Priority: Blocker
>
> If I run my youtube.liq script with window size like 640x480 or else, I get a 
> buggy video size in the output.
> This is surely due to the Lazy settings being evaluated too early. I will fix 
> that before 1.0...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl

Répondre à