[
http://dev.sourcefabric.org/browse/LS-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27169#action_27169
]
Samuel Mimram commented on LS-634:
----------------------------------
I just updated my patch so that it is now possible to write
%define BITRATE 24
%define STEREO true
output.file(%mp3(bitrate = BITRATE, stereo = STEREO),"bla.mp3",s)
(variables are substituted everywhere). To me it now seems useful and clean
enough for what it's meant for...
> Allow some variables in encoding formats
> ----------------------------------------
>
> Key: LS-634
> URL: http://dev.sourcefabric.org/browse/LS-634
> Project: Liquidsoap
> Issue Type: New Feature
> Components: Liquidsoap
> Reporter: Samuel Mimram
>
> We should allow some simple variables in encoding formats, otherwise some
> users (airtime) are starting to get an exponential blowup in the size of
> their scripts... I think that an easy solution would be to replace the
> variables by their value at preprocessing time (we don't want to have a value
> environment when doing type inference, so it has to be resolved before that).
> For instance, Martin Konečný reported this on the ML:
> The reason I brought this up, is because currently our code is as follows:
> output_mono = (...)
> output_stereo = (...)
> if type == "mp3" then
> if bitrate == 24 then
> if stereo then
> ignore(output_stereo(%mp3(bitrate = 24, stereo = true),
> !source))
> else
> ignore(output_mono(%mp3(bitrate = 24, stereo = false),
> mean(!source)))
> end
> elsif bitrate == 32 then
> if stereo then
> ignore(output_stereo(%mp3(bitrate = 32, stereo = true),
> !source))
> else
> ignore(output_mono(%mp3(bitrate = 32, stereo = false),
> mean(!source)))
> end
> elsif bitrate == 48 then
> if stereo then
> ignore(output_stereo(%mp3(bitrate = 48, stereo = true),
> !source))
> else
> ignore(output_mono(%mp3(bitrate = 48, stereo = false),
> mean(!source)))
> end
> Multiply for all bitrates up to 320kbps, then once again for %vorbis, and
> then once again for shoutcast :)
> Right now it's not so bad, but in the future if we add one more user
> customizable variable, it would be wiser to use a code generator :)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://dev.sourcefabric.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Savonet-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-devl
