Ok great Samuel, that was a quick turn-around :). Will prepare these changes for an upcoming Airtime release. Any planned date of an upcoming 1.0.2 release?
Martin On Tue, Jan 1, 2013 at 12:23 PM, Samuel Mimram <[email protected]> wrote: > Actually, when adding audio_to_stereo, the stream plays alright! Without, > we're hit by http://dev.sourcefabric.org/browse/LS-631 once again... > > > On Tue, Jan 1, 2013 at 2:53 PM, Samuel Mimram <[email protected]> wrote: > >> Hi, >> >> We had two problems here. The first one was that redirections to a not >> full url (such as "/blabla" instead of "http://server/blabla";) were not >> handled correctly, this should be fixed in >> https://github.com/savonet/liquidsoap/commit/f369f21286f8bd2493591a8b4ff9e155973e39fa >> >> But why was there a redirection? The answer is that we were fetching >> http://173.192.70.140:7392/stream/1 instead of >> http://173.192.70.140:7392/stream/1/ (notice the trailing slash...). >> This was due to the Http.sanitize function called on urls: Prce.split >> ~pat:"/" "a/////b//c//" returns ["a";"b";"c"] and thus the trailing slash >> is lost. I have fixed this in >> https://github.com/savonet/liquidsoap/commit/cad6589840055345d58c225f05f6165183df0582 >> >> Romain could have a quick look those commits and tell me if they are >> decent to you? >> >> Now, the stream is still not playing but this is because of an "Incorrect >> stream type!" error... Maybe later for this one... >> >> ++ >> >> Sam. >> >> >> On Mon, Dec 31, 2012 at 9:05 PM, Martin Konečný < >> [email protected]> wrote: >> >>> One of our users reported that some streams were failing to play. Upon >>> further inspection, I've found that some streams can cause Liquidsoap to >>> crash. Here is the bug in it's simplest form: >>> >>> liquidsoap 'output.alsa(mksafe(input.http(" >>> http://173.192.70.140:7392/stream/1/";)))' >>> >>> This appears to be a very ordinary webstream (no redirects). Here are >>> the headers: >>> >>> > GET /stream/1/ HTTP/1.1 >>> > User-Agent: curl/7.22.0 (x86_64-pc-linux-gnu) libcurl/7.22.0 >>> OpenSSL/1.0.1 zlib/1.2.3.4 libidn/1.23 librtmp/2.3 >>> > Host: 173.192.70.140:7392 >>> > Accept: */* >>> > >>> { [data not shown] >>> ICY 200 OK >>> icy-notice1:<BR>This stream requires <a href="http://www.winamp.com/ >>> ">Winamp</a><BR> >>> icy-notice2:SHOUTcast Distributed Network Audio Server/posix(linux x86) >>> v2.0.0.29<BR> >>> icy-name:LRN.FM - 64k - The Liberty Radio Network >>> icy-genre:talk >>> icy-url:http://LRN.FM >>> content-type:audio/mpeg >>> icy-pub:1 >>> icy-br:64 >>> >>> Any ideas? >>> >>> M >>> >>> >>> -- >>> Open source radio in the cloud. Get yours now! ---> http://airtime.pro >>> >>> Martin Konecny >>> Software Developer, Sourcefabric >>> [email protected] >>> >>> 720 Bathurst St. Suite 203 >>> M5S 2R4, Toronto, ON, Canada >>> +1 (416) 892-8420 (Cell) >>> Skype: martin.konecny15 >>> >>> http://www.sourcefabric.org >>> http://www.twitter.com/Sourcefabric >>> >>> >>> ------------------------------------------------------------------------------ >>> Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, >>> MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current >>> with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft >>> MVPs and experts. SALE $99.99 this month only -- learn more at: >>> http://p.sf.net/sfu/learnmore_122412 >>> _______________________________________________ >>> Savonet-users mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/savonet-users >>> >>> >> > -- Open source radio in the cloud. Get yours now! ---> http://airtime.pro Martin Konecny Software Developer, Sourcefabric [email protected] 720 Bathurst St. Suite 203 M5S 2R4, Toronto, ON, Canada +1 (416) 892-8420 (Cell) Skype: martin.konecny15 http://www.sourcefabric.org http://www.twitter.com/Sourcefabric
------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612
_______________________________________________ Savonet-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/savonet-users
