I just deployed this new version (I noticed it's merged into master branch
now), so will monitor closely and keep you guys up-to-date for the next few
days.
On Tue, Jan 29, 2013 at 12:30 PM, Romain Beauxis <[email protected]>wrote:
> Hi Martin!
>
> 2013/1/28 Martin Konečný <[email protected]>:
> > We've had a few instances in the past few weeks where Liquidsoap would
> stop
> > responding to telnet commands. I've tried my best to track down the
> source
> > of this problem, but with no luck thus far.
> >
> > It appears to happen randomly when "kicking" an input.harbour source via
> > harbor_id.kick. Once this happens, the Liquidsoap process is still
> running,
> > and I can even telnet in, but any telnet command sent will block with no
> > response from Liquidsoap.
> >
> > I'm going to look into whether I can get more information, what's the
> best
> > place to start? So far I've done set("log.level", 5), any other tips to
> help
> > track this down?
>
> While working on supporting external decoders for streams, I realized
> that some operations done in input.http and input.harbor were not
> thread-safe.
>
> Typically, closing the harbor would be done in a duppy thread and
> could result in a race condition with the main thread reading data off
> that socket. Finally, duppy's tasks would be messed up, resulting in
> the symptoms you describe.
>
> I have addressed all I've been able to spot in a pending PR there:
> https://github.com/savonet/liquidsoap/pull/16
>
> It'd be nice if you could rebuild from this branch and see if you are
> able to reproduce your issue with this code..
>
> Thanks!
> Romain
>
--
Open source radio in the cloud. Get yours now! ---> http://airtime.pro
Martin Konecny
Software Developer, Sourcefabric
[email protected]
720 Bathurst St. Suite 203
M5S 2R4, Toronto, ON, Canada
+1 (416) 892-8420 (Cell)
Skype: martin.konecny15
http://www.sourcefabric.org
http://www.twitter.com/Sourcefabric
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Savonet-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-users
