Le 19/06/2013 04:44, David Baelde a écrit :
> Hi Gilou,
> 
> Thanks for investigating more. I wonder what it could be. If you're
> using a regular playlist (not playlist.safe) then the files are not
> checked in advance, so really the only thing that changes with the
> size of the playlist is parsing time. What you said is consistent with
> this: you have the same problem with a smaller playlist. After that
> point, one possible source of slowdown is if a file takes forever to
> check before loading into the queue. Perhaps can you identify
> problematic files and see how long "liquidsoap -r <file>" takes on it.
> 
> Good luck,


Well, now I know.. I ran a liq script on a playlist made of all the m4a
of the former playlist... And used liq -r on the first file (#2 on the
list, yey) encountered that made the script using 100% of the CPU:

$ time liquidsoap -r "01 Lighters Up (feat. Mavado & Popcaan) 1.m4a"


^C
real    11m30.613s
user    4m30.589s
sys     6m57.990s

(I went for a coffee, otherwise I wouldn't have had it run for that long
hehe ;))

So unless liq or the .m4a decoder has something against Snoop Lionny
Dog, I guess that's a bug, unfortunately probably linked to the file
format.. I can share the file if needed. From my not-so-developper
experience, I'd say the XML part looks suspicious hehe..

Here's what mediainfo has to say about the file (I xxx'ed the iTunes
shitty identifying tags):

General
Complete name                            : 01 Lighters Up (feat. Mavado
& Popcaan)
 1.m4a
Format                                   : MPEG-4
Format profile                           : Apple audio with iTunes info
Codec ID                                 : M4A
File size                                : 7.88 MiB
Duration                                 : 3mn 46s
Overall bit rate mode                    : Variable
Overall bit rate                         : 291 Kbps
Album                                    : Lighters Up (feat. Mavado &
Popcaan) - Single
Album/Performer                          : Snoop Lion
Part/Position                            : 1
Part/Total                               : 1
Track name                               : Lighters Up (feat. Mavado &
Popcaan)
Track name/Position                      : 1
Track name/Total                         : 1
Performer                                : Snoop Lion
Composer                                 : Calvin Broadus, Andrew
Hershey, Wayne Henry, Andrew Bain, David Con
stantine Brooks & Andrae Sutherland
Genre                                    : Hip Hop
Recorded date                            : UTC 2012-12-18 08:00:00
Tagged date                              : UTC 2013-05-08 23:02:44
Cover                                    : Yes
apID                                     : [email protected]
cnID                                     : XXXXXXXXX
rtng                                     : 0
atID                                     : XXXXXXXXX
cmID                                     : XXXXXXXXX
plID                                     : XXXXXXXXX
geID                                     : 18
sfID                                     : XXXXXXX
stik                                     : 1
purd                                     : 2013-03-27 08:39:05
xid                                      : XXXXXXXXXXXXXXX
flvr                                     : 2:256
iTunMOVI                                 : <?xml version="1.0"
encoding="UTF-8"?> / <!DOCTYPE plist PUBLIC "-/
/Apple//DTD PLIST 1.0//EN"
"http://www.apple.com/DTDs/PropertyList-1.0.dtd";> / <plist
version="1.0"> / <dict>
/       <key>asset-info</key> /         <dict> /
<key>file-size</key> /          <integer>80567
15</integer> /          <key>flavor</key> /
<string>2:256</string> /        </dict> / </dict> / </
plist>

Audio
ID                                       : 1
Format                                   : AAC
Format/Info                              : Advanced Audio Codec
Format profile                           : LC
Codec ID                                 : 40
Duration                                 : 3mn 46s
Bit rate mode                            : Variable
Bit rate                                 : 265 Kbps
Maximum bit rate                         : 422 Kbps
Channel(s)                               : 2 channels
Channel positions                        : Front: L R
Sampling rate                            : 44.1 KHz
Compression mode                         : Lossy
Stream size                              : 7.11 MiB (90%)
Language                                 : English
Tagged date                              : UTC 2013-03-27 09:39:20

Cheers,

Gilles

> 
> David
> 
> On Tue, Jun 18, 2013 at 9:01 PM, Gilou <[email protected]> wrote:
>> Le 18/06/2013 10:24, Gilou a écrit :
>>> Le 18/06/2013 08:43, David Baelde a écrit :
>>>> Hi Gilou,
>>>>
>>>> What kind of playlist format are you using? I just tested with a 10k
>>>> playlist and it worked reasonably:
>>>
>>> Normal playlist, but it seems I'm hitting another bug.. I restricted all
>>> the list to 500 elements, but after some time (between 1 and 6 hour),
>>> liq start using all my CPU again.. So I need to do some more investigation..
>>>
>>> I'm running 1.1.1, on a .m3u (text, really) playlist made of .mp3s &
>>> .m4a.. my next step is to use only .mp3 and see how that goes..
>>
>> Yeah.. I think the issue is more related to some kind of files than the
>> playlist size in the end.. I restricted to .mp3, and it seems steady.
>> Still investigating. .m4a / AAC seems to be guilty.. Anything bad to
>> know about those files on liquidsoap ?
>>
>> Cheers,
>> Gilles
>>
>>>
>>> Cheers
>>> Gilles
>>>>
>>>> $ time liquidsoap
>>>> 'print(string_of(list.nth(playlist.parse("~/tmp/10k.txt"),0)))'
>>>>
>>>> It also works well when just doing out(playlist("~/tmp/10k.txt")). I'm
>>>> using the same file on each line, but I don't think that it triggers
>>>> any optimization.
>>>>
>>>> That being said, the code can certainly be optimized. I could easily
>>>> do it if it's about the basic playlist parser -- for more structures
>>>> formats, it might be more difficult and even impossible when we use an
>>>> external lib.
>>>>
>>>> Cheers,
>>>>
>>>> David
>>>>
>>>> On Tue, Jun 18, 2013 at 3:24 AM, Gilou <[email protected]> wrote:
>>>>> Hi,
>>>>>
>>>>> Is there a file number limit on playlist() ? I tried to do it on a 2000+
>>>>> list, and it choke on it, using 100% CPU. It was still streaming the
>>>>> fallback though, good job on that hehe..
>>>>>
>>>>> Anyway, it seems limiting to <2000 works.. But maybe that's a bug.. Or
>>>>> maybe we are just not supposed to have playlists that big...
>>>>>
>>>>> Cheers
>>>>>
>>>>> Gilou
>>>>>
>>>>> ------------------------------------------------------------------------------
>>>>> This SF.net email is sponsored by Windows:
>>>>>
>>>>> Build for Windows Store.
>>>>>
>>>>> http://p.sf.net/sfu/windows-dev2dev
>>>>> _______________________________________________
>>>>> Savonet-users mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/savonet-users
>>>>
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> This SF.net email is sponsored by Windows:
>>>
>>> Build for Windows Store.
>>>
>>> http://p.sf.net/sfu/windows-dev2dev
>>> _______________________________________________
>>> Savonet-users mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/savonet-users
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>>
>> Build for Windows Store.
>>
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> Savonet-users mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/savonet-users
> 
> 
> 


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Savonet-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-users

Reply via email to