----- Original Message ----- > From: "Shawn Wells" <[email protected]> > To: [email protected] > Sent: Monday, July 7, 2014 5:40:14 PM > Subject: Re: [PATCH] [*/utils/verify-input-sanity.py] Enhance 7031613 change > -- show also what kind of error happened > & line number it happened at > > > On 7/7/14, 9:23 AM, Jan Lieskovsky wrote: > > > > This patch enhances the change introduced in: > [1] > https://git.fedorahosted.org/cgit/scap-security-guide.git/commit/?id=7031613 > it to be yet more verbose. Instead of reporting just file name, the error > happened in, > report also what kind of error happened & particular line number of that > processed file, > causing / leading to this error. > > Current verify-input-sanity.py output: > > utils]$ ./verify-input-sanity.py > > XML syntax error in file: > src/input/checks/platform/rhel6-cpe-dictionary.xml > XML syntax error in file: src/input/auxiliary/stig_overlay.xml > > Output once the change is applied: > > utils]$ ./verify-input-sanity.py > > XML syntax error in file > src/input/checks/platform/rhel6-cpe-dictionary.xml: > XML declaration allowed only at the start of the document, line 1, column > 49 > > XML syntax error in file src/input/auxiliary/stig_overlay.xml: > XML declaration allowed only at the start of the document, line 1, column > 49 > > The patch changes the behaviour all across the content (i.e. for > verify-input-sanity.py > foreach of RHEL/6, RHEL/7, Fedora, Openstack & RHEVM3 -- tested for all > cases, works fine). > > Please review. > > Thank you && Regards, Jan. > -- > Jan iankko Lieskovsky / Red Hat Security Technologies Team > > 0001-utils-verify-input-sanity.py-Enhance-7031613-change-.patch > From 3de86a9c94c5b2fdf804183b54c2585802d65841 Mon Sep 17 00:00:00 2001 > From: Jan Lieskovsky <[email protected]> Date: Mon, 7 Jul 2014 15:05:52 > +0200 > Subject: [PATCH] [*/utils/verify-input-sanity.py] Enhance 7031613 change -- > together with reporting in which file the error happened, report also what > kind of error is it & particular line number of the corresponding file > causing it > > Signed-off-by: Jan Lieskovsky <[email protected]> ---
[..] > ack Thank you. Pushed to master. Regards, Jan. -- Jan iankko Lieskovsky / Red Hat Security Technologies Team > > -- > SCAP Security Guide mailing list > [email protected] > https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide > https://github.com/OpenSCAP/scap-security-guide/ -- SCAP Security Guide mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide https://github.com/OpenSCAP/scap-security-guide/
