On Thu, Jan 22, 2009 at 04:42:59PM -0800, David Schleef wrote: > On Thu, Jan 22, 2009 at 10:21:32PM +0000, [email protected] wrote: > > From: David Flynn <[email protected]> > > > > A reorder buffer allows simple solving of what is the earliest decodable > > picture in a sequence. This occurs by doing an insertion sort when > > adding pictures to the reorder buffer based on the ordinality of picture > > number. > > I would prefer renaming the structure member reorder_buffer to > reorder_queue, or leave it as picture_queue. I'd like to reserve > the name "buffer" for things that are related to SchroBuffer. > > (Of course, SchroBuffer is not a "buffer" in the true sense at all. > We'll quietly sweep that fact under the rug.)
Oh good grief. I accidentally pushed your patches with reorder_buffer renamed to reorder_queue. After I did the merging work, I changed my mind and decided to do a rename commit *after* pushing your patches verbatim. Oops. I noticed one problem: in a local branch that contains some gstreamer plugin changes, the first patch causes the decoder element to pull pictures occasionally in the wrong order. I have a hunch that this is related to frame dropping. dave... ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Schrodinger-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/schrodinger-devel
