On Thu, Nov 10, 2011 at 12:06:15AM +0100, Gael Varoquaux wrote: > On Wed, Nov 09, 2011 at 11:43:40PM +0100, bthirion wrote: > > > What do people think? Should I:
> > > 1. change graph_lasso to take the empirical covariance as an input > > > 2. add an 'X_is_cov' parameter to the estimators > > +1 for the second one. > I actually was suggesting both, and 1 as a mean for 2. “No battle plan survives contact with the enemy.” -- Helmuth von Moltke I coded strategy 2, and it turns out that it really doesn't play well with the CV estimators, so I fell back to implementing only 1, and worrying about 2 later. I think that I am ready to merge. G ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Scikit-learn-general mailing list Scikit-learn-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/scikit-learn-general