2012/10/23 Mathieu Blondel <[email protected]>: > Having a single method (I like the name `from_estimator`) does seem cleaner > and easier to follow. > > On Tue, Oct 23, 2012 at 6:18 PM, Olivier Grisel <[email protected]> > wrote: >> >> >> If people don't like the additional methods, we could introduce >> additional boolean or categorical flags. > > > Another solution is to use mixins (ClassificationMetric, RegressionMetric, > MulticlassMetric, ...) and use isinstance to inspect the capabilities.
I would rather avoid `isinstance` checks to keep our API ducktype friendly for 3rd party integration that would not like to use our mixins for one reason or another. But +1 for mixins for code reuse. -- Olivier http://twitter.com/ogrisel - http://github.com/ogrisel ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
