Hi Alex,Indeed, this solution wouldn't break anything but I generally avoid letting the parameters change the return type of a function. Is this approach used somewhere else in scikit-learn?
After the modification of extract_patches_2d, I will probably modify reconstruct_from_patches_2d. I would add the possibility to:
* disable the averaging * use the coordinates to reconstruct the image with only a subset of the patches Nicolas On 04/21/2013 10:01 PM, Alexandre Gramfort wrote:
hi Nicolas, I would add a bool parameter to extract_patches_2d such as return_coordinates. If True it returns (patches, coords) Alex ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
