I have pushed all fixes requested by other participants on my pull request.
On Fri, Jul 26, 2013 at 3:30 PM, Joseph Turian <[email protected]> wrote: > Can I get my feature into this version? > https://github.com/scikit-learn/scikit-learn/pull/2176 > > I was going to push fixes this weekend, to address everyone's comments. > > On Thu, Jul 25, 2013 at 8:40 AM, Lars Buitinck <[email protected]> wrote: >> 2013/7/25 Jacob Vanderplas <[email protected]>: >>> On Thu, Jul 25, 2013 at 7:44 AM, Andreas Mueller <[email protected]> >>> wrote: >>>> >>>> There seems to be also a separate issue about cython compatibility. The >>>> current cython version >>>> doesn't like sklearn/neighbors/binary_tree.pxi. It warns about undefined >>>> behavior because you use indexing like X[:-1] >>>> when running cython and segfaults when run. >>> >>> Hmm, strange that wasn't a problem under cython 0.18. That issue seems much >>> easier to fix though. >> >> What is X here? An array, a pointer, a memoryview? >> >> -- >> Lars Buitinck >> Scientific programmer, ILPS >> University of Amsterdam >> >> ------------------------------------------------------------------------------ >> See everything from the browser to the database with AppDynamics >> Get end-to-end visibility with application monitoring from AppDynamics >> Isolate bottlenecks and diagnose root cause in seconds. >> Start your free trial of AppDynamics Pro today! >> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk >> _______________________________________________ >> Scikit-learn-general mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/scikit-learn-general > > > > -- > Joseph Turian, Ph.D. | President, MetaOptimize > "Optimize Profits. Optimize Engagement." > http://metaoptimize.com > 855-ALL-DATA > > The web's best forum for data scientists: http://metaoptimize.com/qa/ -- Joseph Turian, Ph.D. | President, MetaOptimize "Optimize Profits. Optimize Engagement." http://metaoptimize.com 855-ALL-DATA The web's best forum for data scientists: http://metaoptimize.com/qa/ ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ Scikit-learn-general mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/scikit-learn-general
