Andy,

Indeed, this will mostly depend on the number of public utils we have.
However, using submodules can help structure our public utils.

M.

On Wed, Sep 17, 2014 at 6:32 PM, Andy <[email protected]> wrote:

> On 09/15/2014 03:40 PM, Mathieu Blondel wrote:
>
>> lightning is using the following utils:
>>
>> - check_random_state
>> - safe_sparse_dot
>> - shuffle
>> - safe_mask
>> - sklearn.utils.testing.*
>>
>> The latter is not big deal but I like importing assertions from the same
>> place.
>>
>> On a second thought, importing all public utils in __init__.py might
>> quickly become messy.
>> I like Andy's propsal of having no imports at all in __init__.py.
>> I suggest we move everything in __init__.py to a suitable submodule.
>>
>
> What I had in mind was importing into sklearn.utils but not implementing
> in __init__.py but I don't have a strong opinion.
> Why do you think importing into utils gets messy? Because it there are so
> many functions that we want public (are there? I don't know ;)
>
>
>
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Scikit-learn-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/scikit-learn-general

Reply via email to