I've been looking through the code and several things have jumped out at me.

Parts of a platform's implementation is included in the portability library, 
when imo, it should all be in the individual platform's code. All the ifdef 
PLAT_GTK etc.

In my view, it would make more sense for the "portability library" to include 
nothing but some virtual interfaces, and have the specific platform code 
subclass those. This would allow the platform code to use the objects as the 
subclassed objects, while the editor can just assume the base features exist.

I'm really wondering what led to the current design, it seems like what I 
suggest was intended originally, but other things were happhazardly hacked in 
on top of things, making rather more difficult to add a new platform (in my 
case, Qt4).

-- 
Thomas Fjellstrom
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to