I hope that this list is the correct place for these kind of requests.
I'm working with my own Qt implementation and looking at the changes
I've made in core scintilla code that I may need to merge into the
new release if I decide to update.
In ExternalLexer.h:
#if PLAT_WIN
#define EXT_LEXER_DECL __stdcall
#elif PLAT_GTK
#define EXT_LEXER_DECL
#endif
How is this handled on the other platforms? Shouldn't that be:
#if PLAT_WIN
#define EXT_LEXER_DECL __stdcall
#else
#define EXT_LEXER_DECL
#endif
In Editor.cxx:
#ifndef PLAT_QT
#define INCLUDE_DEPRECATED_FEATURES
#endif
I wonder whose benefit this is for? I notice that PLAT_QT isn't
defined in Platform.h. In any case it doesn't look like undefining
INCLUDE_DEPRECATED_FEATURES is supported since it guards the
definition of SCN_POSCHANGED but doesn't guard its use in
Editor.cxx. This should be:
#define INCLUDE_DEPRECATED_FEATURES
Thanks for the consideration.
Jason Haslam
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
