Robert Roessler wrote:
Neil Hodgson wrote:
Robert Roessler:
I notice that there was a change to ScintillaGTK.cxx (rev 1.156)...
Yes, this was a quite significant change for SCN_URIDROPPED users.
With recent versions of Nautilus, dragging a file includes both the
name as text and the URI. Earlier versions of Scintilla would grab the
text and add this into the document. The change means that the URI is
checked for first which should allow URIs to be detected. I cleaned up
some more of the clipboard format code at this time but the changes
should only have removed unused code. The previous modification by
John Ehresman also touched this code.
Confirmed - the 1.156 change broke simple, workable code (at least for
the GTK Scintilla on Windows situation)... and since a later
"adjustment" turned off the [now] "error" notification, this is silent.
How can we get the old working back? I am glad that Nautilus users are
happy and all, but a fix for that group should not have invalidated
functioning code... it's not as if I was using some strange undocumented
behavior of Scintilla - I just expected it to work as documented (drops
in Scintilla windows cause SCN_URIDROPPED notifications) - and it *did*. ;)
Yup - just restoring the original [subtracted] code for the else
clause works fine... I copied the reported diff lines back in, so that
it supports both the old logic and the new breaking logic - with the
new being given a shot first, and the original code only being run if
the new uri recognition stuff fails.
This seems the minimal change - no refactoring, just put back the
working code *in addition* to the new stuff that broke things... I
really hope this restoration of already-known-to-work code can be
considered good enough for the impending release. :)
I will post the file if Neil or anyone else wants it... ;)
Robert Roessler
[EMAIL PROTECTED]
http://www.rftp.com
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest
