Feature Requests item #1564890, was opened at 2006-09-25 00:45
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=352439&aid=1564890&group_id=2439

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Scintilla
Group: None
Status: Open
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Send SCN_HOTSPOTCLICK/SCN_HOTSPOTDOUBLECLICK on mouse up

Initial Comment:
In most cases hotspots are used to open new files, and
as they are sent onmousedown it causes a selection to
occur if one clicks the hotspot.  It makes more sense
to me to have it occur on onmouseup.  The modified code is:

Editor.h:
Line 501 to void ButtonUp(Point pt, unsigned int
curTime, bool shift, bool ctrl, bool alt);

Editor.cxx:
Line 5456 add:
bool inSelMargin = PointInSelMargin(pt);
if(!inSelMargin && PointIsHotspot(pt))
{
        int newPos = PositionFromLocation(pt);
        newPos = MovePositionOutsideChar(newPos, currentPos -
newPos);
        NotifyHotSpotClicked(newPos, shift, ctrl, alt);
}
Line 2229 remove:
if (PointIsHotspot(pt)) {
    NotifyHotSpotClicked(newPos, shift, ctrl, alt);
}

ScintillaWin.cxx:
Line 678 to:
ButtonUp(Point::FromLong(lParam), ::GetMessageTime(),
(wParam & MK_SHIFT) != 0, (wParam & MK_CONTROL) != 0,
(wParam & MK_ALT) != 0);

I haven't modified this for GTK.

Cheers.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=352439&aid=1564890&group_id=2439
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to