Bugs item #1665791, was opened at 2007-02-21 19:42
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102439&aid=1665791&group_id=2439

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Scintilla
Group: Bug
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mike Roberts (mjroberts)
Assigned to: Nobody/Anonymous (nobody)
Summary: SCI_LINESJOIN figures wrong range endpoint

Initial Comment:
This tends to be noticeable only if you join a number of very short lines - for 
example, select the first three lines of this text and call SCI_LINESJOIN:

a
b
c
d
e
f

The problem is that Editor::LinesJoin() isn't adjusting targetEnd for the extra 
space it inserts between joined lines, so the join stops early.

The fix is: at line 1630 of scintilla/src/Editor.cxx, right after 
pdoc->InsertChar(pos, ' '), add this:

targetEnd += 1;

(Or maybe += pdoc->LenChar(pos) to be fully MBCS-safe, but presumably ' ' 
always has length 1.)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=102439&aid=1665791&group_id=2439
_______________________________________________
Scintilla-interest mailing list
[email protected]
http://mailman.lyra.org/mailman/listinfo/scintilla-interest

Reply via email to