Neil Hodgson wrote:

I've noticed that I am not deleteing the job object within
ProcessExecute().  I would like to:
- add a variable exitstate to the job class
- return the job as a void * instead of the exitstate

This way the IDM_FINISHEDEXECUTE code can get the exit state and build
flags.
  Wouldn't it be better if the IDM_FINISHEDEXECUTE was able to remove
the finished job object safely and query it for the file path and
status?

Hi Neil.

The SciTEWin::ProcessExecute() method currently pops a job off the queue, and I've modified IDM_FINISHEDEXECUTE to receive the job as a parameter via lparam. I have not altered anything to store the buffer name so far, but the new code is working.

Oh, I am also planning on on having IDM_FINISHEDEXECUTE delete the job object.

I think that is what you are suggesting. BTW, which is a 'better' means of assigning the buffer name to the job object:
1. adding a parameter to AddCommand(), or
2. utilizing CurrentBuffer() within AddCommand() - this absolutely depends on the buffer being unchanged between the time the AddCommand() is called and the job object is created

April

--
Good judgment comes from experience. Experience comes from bad judgment.
-- Jim Horning

_______________________________________________
Scite-interest mailing list
Scite-interest@lyra.org
http://mailman.lyra.org/mailman/listinfo/scite-interest

Reply via email to