[ http://jira.codehaus.org/browse/SCM-119?page=comments#action_53564 ]
Neil Padgen commented on SCM-119: --------------------------------- I understand your point, Mike, but this issue will stop me from using Continuum until those plugins are changed. Our processes depend on inspecting those existing reports. I haven't tried the release plugin, but I assume that it will currently fail if the SCM URL is designed for those report plugins to work. Existing projects will also break if suddenly the reports need a different URL to the one they have been using for months if not years. Surely it would make sense to "be lenient in what you accept and strict in what you produce", by not appending a "/..." to the depot path for p4 commands if there is already one in the depot path - while still persuading the report plugin's authors to change to using the SCM plugin. > Perforce provider should only append "/..." to view if necessary > ---------------------------------------------------------------- > > Key: SCM-119 > URL: http://jira.codehaus.org/browse/SCM-119 > Project: Maven SCM > Type: Bug > Components: maven-scm-provider-perforce > Reporter: Neil Padgen > Attachments: patch > > > When creating a clientspec, maven-scm-provider-perforce currently appends > "/..." to the SCM URL regardless of what is already there. But other plugins > (such as the changelog-report-plugin, file-activity-report-plugin and > developer-activity-report-plugin) require the SCM URL to end in "/..." to be > able to produce output. > Fix: when creating the clientspec, only append "/..." if it is not already > there. > (I'm not sure if "p4 filelog" is invoked by this component or those other > report plugins.) > *Untested* patch attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
