Title: [waffle-scm] [510] trunk/waffle-core/src/main/java/org/codehaus/waffle/action/AbstractMethodDefinitionFinder.java: removed private method, its name caused confusion to its true intent
Revision
510
Author
mward
Date
2007-12-18 22:12:36 -0600 (Tue, 18 Dec 2007)

Log Message

removed private method, its name caused confusion to its true intent

Modified Paths


Diff

Modified: trunk/waffle-core/src/main/java/org/codehaus/waffle/action/AbstractMethodDefinitionFinder.java (509 => 510)

--- trunk/waffle-core/src/main/java/org/codehaus/waffle/action/AbstractMethodDefinitionFinder.java	2007-12-19 03:54:59 UTC (rev 509)
+++ trunk/waffle-core/src/main/java/org/codehaus/waffle/action/AbstractMethodDefinitionFinder.java	2007-12-19 04:12:36 UTC (rev 510)
@@ -69,7 +69,7 @@
                                  HttpServletResponse response) throws WaffleException {
         String methodName = methodNameResolver.resolve(request);
 
-        if (isDefaultActionMethod(methodName)) {
+        if (methodName == null) {
             return findDefaultActionMethod(controller, request);
         } else if (isPragmaticActionMethod(methodName)) { // pragmatic definition takes precedence
             return findPragmaticActionMethod(controller, methodName, request, response);
@@ -78,10 +78,6 @@
         }
     }
 
-    private boolean isDefaultActionMethod(String methodName) {
-        return methodName == null;
-    }
-
     private boolean isPragmaticActionMethod(String methodName) {
         return methodName.contains(PRAGMA_SEPARATOR);
     }
@@ -286,7 +282,7 @@
     }
 
     private boolean isEmpty(String value) {
-        return isDefaultActionMethod(value) || value.length() == 0;
+        return value == null || value.length() == 0;
     }
 
     // Protected methods, accessible by  subclasses


To unsubscribe from this list please visit:

http://xircles.codehaus.org/manage_email

Reply via email to