[xstream-scm] [jira] (XSTR-764) Validation of readResolve() result

[Roy Zahor (JIRA)]

Title: Message Title

Roy Zahor created an issue   XStream / XSTR-764 Validation of readResolve() result Issue Type: Improvement Affects Versions: 1.4.7 Assignee: Jörg Schaible Attachments: SerializationMethodInvoker.java.patch Components: Converters Created: 08/Dec/14 8:30 AM Priority: Minor Reporter: Roy Zahor Hi, I would like to suggest a small fix that would check that the result of a readResolve() call is not null. While developing with XStream, I forgot to return the object in my readResolve() implementation, and the unmarshaling process continued without throwing any exception, resulting with a null object. It took me several hours to understand that the cause for a null object is my wrong readResolve() implementation. In this case I recommend to throw a descriptive exception that will help the developer to understand that something is wrong with their readResolve() implementation instead of returning a null object. The suggested fix is to replace line 66 in SerializationMethodInvoker from: return readResolveMethod.invoke(result); to: Object invokeResult = readResolveMethod.invoke(result); if (invokeResult == null) throw new ObjectAccessException(resultType.getName() + ".readResolve() returned null"); return invokeResult; Attached please find SVN patch file. I have run all unit tests and they completed successfully after applying this fix. Add Comment   This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) To unsubscribe from this list please visit: http://xircles.codehaus.org/manage_email