Hi,
Kristis, I'll send the other changes needed to add support for Bugzilla-4 in
a separate thread. Adding simple comment basically works with the old code
but changing status requires a bit more changes and maybe there are some
other things to refine (I have some progress with these. Just I got a bit
stuck while testing since I faced an issue with my old workaround for the
problem of passing non-ascii Unicode svn commit messages: Setting UTF-8
locale causes problems with mod-dav-svn needs to return an error message
containing Unicode text...).
Anyway:
what about sub BINMODE { binmode(@_) } instead of sub BINMODE {
binmode($_[0]) }? binmode has several (two) parameters and Bugzilla passes
both of them.
I'm not familiar with tie, Tie::StdHandle, etc. But looking at the current
situation: what will happen if Bugzilla writes to STDERR using write (or
some other function) instead of print. When print is used - I suppose we
shouldn't care about binmode of STDERR since we're delegating that work to
logger appenders (yes, it makes sense to make appenders unicode aware but
that's decoupled when using Logger and should be configured elsewhere).
Yavor
2010/11/8 Thorsten Schöning <[email protected]>
> Guten Tag Kristis Makris,
> am Montag, 8. November 2010 um 18:03 schrieben Sie:
>
> > Maybe, maybe not. The purpose of Tie::StdHandle seems to be tying
> > databases to variables. We don't need to tie a database to anything.
>
> It seems to be more generally usable with all kinds of things,
> especially file handles like what SCMBug needs to log STDERR.
>
> http://perldoc.perl.org/5.12.0/perltie.html
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning
> AM-SoFT IT-Systeme - Hameln | Potsdam | Leipzig
>
> Telefon: Potsdam: 0331-743881-0
> E-Mail: [email protected]
> Web: http://www.am-soft.de
>
> AM-SoFT GmbH IT-Systeme, Konsumhof 1-5, 14482 Potsdam
> Amtsgericht Potsdam HRB 21278 P, Geschäftsführer: Andreas Muchow
>
> _______________________________________________
> scmbug-users mailing list
> [email protected]
> http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
>
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
