> Is there any downside to using it? (Does it work on py3?) I have not tried myself, as SCons does not run under py3 yet. Sure I might have Part issues with running under py3 as well. However I don't think there are any known issues with running the patch under py3 as of yet.
As far as issues with streaming. I have not seen any locally, given Parts is very sensitive to streaming issues ( as we log and colorize the output data from every task) I feel pretty good about this fix. There might be some issue that exists, but honestly subprocess has always had small issues. Given we are using it in our suite builds, and honestly these builds are huge and very complex ( so happy Scons and Parts make this easy to manage :-) ) and we are having no issues. None of the other team using this code at Intel I know of are happy as well. Given this I feel confident there is low probably anyone will have any problem at all. Jason -----Original Message----- From: scons-dev-boun...@scons.org [mailto:scons-dev-boun...@scons.org] On Behalf Of Dirk Bächle Sent: Wednesday, April 23, 2014 2:08 AM To: SCons developer list Subject: Re: [Scons-dev] Subprocess issue on Linux? On 23.04.2014 01:42, Bill Deegan wrote: > Dirk, > > So if I understand correctly, the stubprocess patch passes all the > regression tests and is signficantly faster than the current > implementation? That's correct, but I'm not sure whether things like the redirection of stdout/stderr works in all cases, or might create quirky problems in certain situations. I just can't judge the technical stability level of the stubprocess.py source. > Is there any downside to using it? (Does it work on py3?) I haven't tried the wrapper under Python3 yet. But as far as I understood Eugene and Jason, it's not implemented. Another downside is that this doesn't work under Windows obviously, I don't have any infos about OSx, and Alexandre Leblot already asked me in a PM about the support for Solaris. I can't test these things, so I've no idea. ;) > If not is there any reason not to send a pull request? > Creating a pull request is probably not difficult, on the technical level. But should the wrapper get activated automatically under Linux, transparently for the user? Or would it be an experimental option at first, that the user can activate via a command-line option...since we aren't that sure about all the possible implications? Dirk _______________________________________________ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev _______________________________________________ Scons-dev mailing list Scons-dev@scons.org http://two.pairlist.net/mailman/listinfo/scons-dev
