Thanks! -Jason ________________________________ From: Bill Deegan <b...@baddogconsulting.com> Sent: Tuesday, October 30, 2018 12:27 PM To: SCons developer list Cc: Jason Kenny Subject: Re: [Scons-dev] testing with python 3.6 3.7
I believe the dictionary order maintenance started in 3.5. We've observed no issues due to this. -Bill On Tue, Oct 30, 2018 at 7:03 AM Mats Wichmann <m...@wichmann.us<mailto:m...@wichmann.us>> wrote: On 10/30/18 7:49 AM, Jason Kenny wrote: > Hi, > I was wondering if SCons had noticed any testing issues with python 3.6 or > newer. I noticed as I was porting Parts to python3 I was having some testing > issues related to testing the output of some values that had been controlled > by values in dict object. I discovered that with python 3.6 and made official > in 3.7 the insert order is preserved. This caused some false positive > failures for me as values. I was just curious if this was seen with the scons > move to python3 as well. > Jason the CI infrastructure (travis and appveyor) builds everything against 3.5, 3.6 and 3.7, so those are seen. There have been several cleanups as a result, but mostly those problems have been noise - 3.6 and 3.7 issuing deprecation warnings by default now, and if those end up in the "expected" stderr stream of a test, then it causes problems for that test. There's also a lot of noise from unclosed file descriptors when launching other processes via subprocess. I don't recall seeing any test affected by dictionary order... some of the code was already using OrderedDict, and I did send a PR through to remove the internal custom OrderedDict in favor of the standard library one. Others may recall something additional... _______________________________________________ Scons-dev mailing list Scons-dev@scons.org<mailto:Scons-dev@scons.org> https://pairlist2.pair.net/mailman/listinfo/scons-dev<https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpairlist2.pair.net%2Fmailman%2Flistinfo%2Fscons-dev&data=02%7C01%7C%7C160a8d9212be4de47e2c08d63e8d1596%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636765173002935843&sdata=mgxmRrmqfPeyBLGpD3GutioxTOtyFC4FJd1cqKh8qOQ%3D&reserved=0>
_______________________________________________ Scons-dev mailing list Scons-dev@scons.org https://pairlist2.pair.net/mailman/listinfo/scons-dev
