On Wed, Jul 30, 2014 at 12:28:39PM -0400, William Bader wrote: > I have posted a version of Juraj's patch that works against 1.5.0svn. > I only had to apply one part by hand, and I changed "pythonScript = > QFile::decodeName(argv()[i + 1]);" to "pythonScript = > QFile::decodeName(args[i + 1].toLocal8Bit());". > http://bugs.scribus.net/view.php?id=12572 > My build environment is only Linux (Fedora 20), but the patch does not seem > to contain anything operating system dependent, and I suspect that Juraj was > being cautious when he said Linux-only because it was never tested under > Windows rather than because there is any reason that it should not work. > At least on Linux, it still opens a window. The window does not need any > user interaction and closes when the script finishes, so that is OK for my > purposes. I imagine that on any x11 environment, you could create a virtual > desktop with vncserver and connect Scribus to the virtual desktop instead of > to a physical screen. > I think that the "ugly" comment relates to the Scribus useGUI variable. When > running a python script, even though there is no GUI, the useGUI variable > must be true, because if it is false, Scribus does not do anything. > The useGUI variable might be better as an enumeration of four values: no GUI > because there were errors on the command line that prevent Scribus from > starting, no GUI because the user specified the --no-gui command line option, > non-interactive GUI because the user is running a script with > --python-script, and normal interactive GUI. Or maybe as several boolean > variables like fatal error, running a python script, gui needed. > If Juraj does not have time to make the changes, and if you can be clear > about what it would take to make the patches acceptable, I would be willing > to try. > Regards,William
Thank You William, it is almost as if You read my mind. I am very grateful that You fixed the patch for 1.5 source and posted it at bug tracker. And I would be honored if you make required changes for patch to be accepted (my 33K dialup connection is main reason I can not be very responsive). Bye Juraj
