On Wed, 6 Dec 2006 17:36:43 +0000 Stuart J Urquhart <[EMAIL PROTECTED]> wrote:
Sorry for the delay i was a bit busy in the last days.
> I decided to modify the palcat tool so that i could pre-append
> palettes onto the processed image.
> Essentially, all this means is that i can specify palette'd images
> before as well as after the image i am looking to process. In
> addition, the colors in the processed image will be shifted according
> to how many palette entries have been prefixed onto it.
Good idea!
> The patch is attached to this message, which also corrects a typo in
> scc_param.c I have tested the modifications, and they seem to work fine.
I applied it with some modifications. However you should avoid mixing
unreleated changes in a patch. For a small patch like this it doesn't
matter much, but it still mean some extra work as i need to take the
changes apart to commit the separetly. I try to avoid mixing changes
bcs it make reading/understanding the diff much harder, in particular
when you read them later on when looking for something in the svn log.
In case you wonder i see 4 changes in that patch: Adding Pre-append,
scc_param fix, error message fix and the extra scc_img_free.
I removed the scc_img_free. Some ppl like to be very strict with that,
but as the OS will just kill the heap when the program exit, i find
it better to keep the code simpler.
I also simplified the pre/append code to spare a few lines of code :)
However I haven't commited the error message fix yet but that should
happend soon.
Albeu
PS: Your MUA set application/octet-stream as mime type for the diff.
A text type would be better :)
pgp8WvdsljdHZ.pgp
Description: PGP signature
_______________________________________________ ScummC-general mailing list [email protected] https://mail.gna.org/listinfo/scummc-general
