On Tue, 27 Nov 2007 19:18:21 +0000
James Urquhart <[EMAIL PROTECTED]> wrote:
> Hey there,
>
> Patch which adds dummy opcodes for ego & actor talk.
Applied with a few modification:
> +static int scvm_op_ego_talk(scvm_t* vm, scvm_thread_t* thread) {
The opcode should be in a comment before the function.
> + scvm_push(vm, vm->var->ego);
> + return scvm_op_actor_talk(vm, thread);
Please try to use the same identation style as the rest of the file.
You might have noticed that there is 2 identation style, that's because
I switched the default in my editor some years ago :/
The old style use 2 space indentation with tabs and spaces.
The new style use 4 space indentation with spaces only.
If things get slighlty messed in files using the old style it's not too
bad, they should be re-indented some day. However I would be glad if no
tab where introduced in the files using the new style.
> +}
> +
> static int scvm_op_dummy_get_at(scvm_t* vm, scvm_thread_t* thread) {
> int r,x,y;
> if((r = scvm_vpop(vm,&y,&x,NULL))) return r;
> return scvm_push(vm,0);
> }
>
> -
Please watch out for such white space changes.
> Would have properly implemented it, but i can't see any system for
> printing strings implemented in scvm yet.
One of the many subsystems totaly missing in scvm :/
Albeu
_______________________________________________
ScummC-general mailing list
[email protected]
https://mail.gna.org/listinfo/scummc-general
