Am Samstag 23 Februar 2008 20:23:29 schrieben Sie:
> Thomas Koch wrote:
> > Hi,
> >
> > as I'm new to eZ Publish (but an old ezc user) I don't know if there are
> > ways to contribute to eZ Publish developing. I'd only like to contribute
> > in code cleanup for the PHP4->5 transition, but no feature developing.
> >
> > Take for example lib/ezutils/classes/ezhttptool.php. None of the methods
> > have static keywords or visibility modifiers. Therefor we have many
> > strict errors with calls like eZHTTPTool::hasSessionVariable.
>
> Most likely these methods are not declared as static because they are
> not static. Use the instance() method first to get the unique instance
> of eZHTTPTool, then call these methods on the instance. To me it seems
> that there haven't been thought much about methods and how they should
> be used in the pre-PHP 5 period of eZ Publish, and it's quite difficult
> to get it done right now without breaking too much BC.
>
> Best regards
>
> Kristof
>
> > I'd happily help in cleaning this up so that I can keep strict in my
> > php.ini for our own code. Would you receive and integrate patches or even
> > give me SVN access? I already signed a CLA.
> >
> > Cheers,
Thanks Kristof,
yes, you're right. I also found, that newer methods in the same class have
visibility modifiers and the static keyword, where necessary.
I did a test and you could still declare those methods static:
public static function hasSessionVariable( $var )
{ ... }
$httpTool = eZHTTPTool::instance();
$httpTool->hasSessionVariable( xyz );
You can call a static method non-static, but not invers.
Still my question is, if eZP development could profit from contributions of
eZ-Partners for simple bug-fixing or code commentations, or if the involvment
of partners would rather slow down the development due to increased
communication work.
Hope you have as nice weather as we have today!
Cheers,
Thomas Koch
--
Thomas Koch, Software Developer
http://www.koch.ro
--
Sdk-public mailing list
[email protected]
http://lists.ez.no/mailman/listinfo/sdk-public
