On Mon, 30 Jun 2008, Derick Rethans wrote: > On Mon, 30 Jun 2008, Tobias Schlitt wrote: > > > On 06/30/2008 12:42 AM James Pic wrote: > > > > > Tobias Schlitt wrote: > > > > >> ezcMvcRequestFilter > > >> ------------------- > > >> > > >> The filters are described to be used in a method named > > >> ezcMvcController->runRequestFilters(), while this method should be > > >> called by ezcMvcController->run(). It does make little sense to me to > > >> mention that a method ezcMvcController->runRequestFilters() should be > > >> implemented at all, if the controller calls the filter itself. > > >> > > >> Instead I would suggest to design it in either of the following ways: > > >> > > >> a) Remove the ezcMvcController->runRequestFilters() part and just > > >> mention that filters should be run by the controller. > > >> b) Require the method ezcMvcController->runRequestFilters() in the > > >> interface and make it be run by the request builder. > > > > > Don't you mean that the request maker should run the filters? > > > Should the selection of filters depend on the controller or the request > > > builder? > > > > The object running the controller should do it. :) > > That poses a problem. It means that the filter selection now has to be > done in the dispatcher, where it clearly belongs to the controller. It > also means that might you have to implement the filter chains multiple > times.
One example why it needs to be in the controller. THe authentication filter should not run for the user/login and user/register actions for example. regards, Derick -- Sdk-public mailing list [email protected] http://lists.ez.no/mailman/listinfo/sdk-public
