Hi kevin, I found out what the problem was; my development system was using the wrong toolchain.
I will build a new patch and compress it and put it on the mailing list. I will make the necessary changes, to go from config.h to Kconfig. So there will be no duality on the configuration. I moved out already the "BIG" banners and made them like more files in your project. Marc On Sun, 2011-01-16 at 16:20 -0500, Kevin O'Connor wrote: > On Sun, Jan 16, 2011 at 09:38:37PM +0100, Marc Bertens wrote: > > Kevin, > > > > Finally here is the patch for Kconfig build system for SeaBIOS, the > > patch exists out of two files; > > 1. kconfig-for-seabios-patch.1.diff this is the part where the new > > files are added. > > 2. kconfig-for-seabios-patch.2.diff this is the part with the > > changes to the existing files. > > Thanks Marc. > > Your patch was too large for the mailing list. Can you put future > versions online somewhere or send compressed? > > > I hope that you agree with the changes :-) and that the kconfig will > > here to stay.... > > > > I loaned the kconfig build system from the coreboot project, maybe there > > are some references there what i missed. > > [...] > > +++ b/src/configh.h > > @@ -0,0 +1,248 @@ > > +/* > > + * This file is part of the seabios project. > > + * > > + * Copyright (C) 2011 Marc Bertens <mbert...@xs4all.nl> > > + * Copyright (C) 2008-2010 Kevin O'Connor <ke...@koconnor.net> > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; version 2 of the License. > [...] > > I really don't like these big copyright banners. I don't see much > point in copyrighting a header file. SeaBIOS is LGPLv3, and all core > files must use that copyright. > > This doesn't apply to non-core files copied from other projects, so > doesn't need to be true for tools/kconfig. > > Also, your first patch modifies seabios, but I thought you were going > to do that in patch2? I don't see a reason to have old way and new > way in parallel - lets just go right to the kconfig way. The way > you've introduced configh.h, configu.h, and configk.h in addition to > the existing config.h is confusing. > > [...] > > --- a/tools/kconfig/Makefile > > +++ b/tools/kconfig/Makefile > > @@ -225,7 +225,7 @@ endif > > $(objk)/gconf.o: $(objk)/.tmp_gtkcheck > > > > ifeq ($(gconf-target),1) > > --include $(objk)/.tmp_gtkcheck > > +include $(objk)/.tmp_gtkcheck > > > > # GTK needs some extra effort, too... > > $(objk)/.tmp_gtkcheck: > > @@ -250,23 +250,23 @@ endif > > > > # --- UNUSED, ignore > > ---------------------------------------------------------- > > ifdef UNUSED > > -$(obj)/zconf.tab.o: $(obj)/lex.zconf.c $(obj)/zconf.hash.c > > +$(obj)/zconf.tab.o: $(srck)/lex.zconf.c $(srck)/zconf.hash.c > > Can you explain what this does? > > -Kevin
_______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
