On Sat, Dec 17, 2011 at 08:06:13PM +0000, Julian Pidancet wrote: > On Sat, Dec 17, 2011 at 4:17 PM, Kevin O'Connor <[email protected]> wrote: > > On Fri, Dec 16, 2011 at 02:15:12PM +0000, Julian Pidancet wrote: > > [...] > >> +struct VbeInfoBlock > >> +{ > >> + u8 signature[4]; > >> + u16 version; > >> + u16 oem_string_off; > >> + u16 oem_string_seg; > > > > Looks like this is the same as "struct vesa_info" defined in > > src/bootsplash.c. It doesn't really matter which struct is used, but > > both areas of code should share the same definition. > > > > Also, I think it would be better to use "struct segoff_s" and to use > > "u32 signature". > > > > They indeed seems to be the same structures. Should I move vbe.h in > src/ and make the definitions common for both the VGA ROM and the BIOS > ?
Yes - I think having them use a shared definition would be best. -Kevin _______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
