On Do, 2014-05-15 at 14:44 +0200, Paolo Bonzini wrote: > Il 13/05/2014 17:00, Kevin O'Connor ha scritto: > > On Tue, May 13, 2014 at 02:58:29PM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >> Digged out an old patch from the mailing list, to make smm use > >> acpi_pm1a_cnt. This allows to make the acpi pmbase a variable > >> and figure where to place the registers at runtime. > >> > >> With these preparations in place we can go move acpi pm registers > >> below 0x1000 for new enougth qemu (2.0+). The whole 0x1000 -> 0xffff > >> range is free then on q35. > > > > The series looks okay to me. > > > > I am a little leery about the way patch one accesses the f-segment > > while in SMM mode. I do the same in my 32bit driver test series - > > see: > > https://github.com/KevinOConnor/seabios/commits/testing-32bit-drivers > > . But, I'm leery about making that kind of change days before tagging > > a new release. > > I think that code can be removed altogether, it should be handled by > QEMU. See the series I just posted.
Swapped patch #1 of my series with patch #2 of your series. Works ok. And just removing the code makes me less nervous than changing the way it works when it comes to merging this last-minute. cheers, Gerd _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios