On Mon, Jun 29, 2015 at 04:33:54PM +0200, Gerd Hoffmann wrote: > Hi, > > > > +u8 vp_get_isr(struct vp_device *vp) > > > +{ > > > + u8 isr; > > > + > > > + if (vp->use_modern) { > > > + vp_modern_read(vp->isr, virtio_pci_isr, isr, isr); > > > + } else { > > > + isr = inb(vp->ioaddr + VIRTIO_PCI_ISR); > > > + } > > > + return isr; > > > +} > > > > How about renaming "use_modern" to something more descriptive - like > > "use_abi1"? Also, couldn't vp_modern_read just be renamed to vp_read. > > In both qemu and linux kernel "legacy" and "modern" are used for the two > interface revisions (0.9.5 and 1.0), and I'd prefer to stay consistent > with that.
Okay - that makes sense. Thanks, -Kevin _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios