On Wed, Dec 30, 2015 at 07:09:54PM -0500, Stefan Berger wrote: > On 12/30/2015 02:31 PM, Kevin O'Connor wrote: > >The low-level measurement functions already handle error conditions, > >there is no need to check for the errors in the high level measurement > >functions. > > > >Signed-off-by: Kevin O'Connor <ke...@koconnor.net> > >--- > > >@@ -507,7 +478,12 @@ tpm_setup(void) > > if (runningOnXen()) > > return; > > This looks like a for Xen where we will be missing too much. Cc'in Xu Quan > for this. I think Xen likely only wants to skip the TPM_Startup in > tpm_startup() but not the retrieval of the durations and timeouts and so on. > This part may need to move.
That makes sense, but note that the position of the check hasn't changed in this series. I wonder if the error from TPM_Startup on Xen could just be ignored as is done for CONFIG_COREBOOT. -Kevin _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org http://www.seabios.org/mailman/listinfo/seabios
