On Fri, Jan 29, 2016 at 07:51:42PM +0800, Cao jin wrote: > Hi, > Am I wrong about this?
The proposed comments aren't wrong, but the previous comments weren't wrong either. I don't think a change is warranted. -Kevin > On 01/25/2016 07:26 PM, Cao jin wrote: > >Signed-off-by: Cao jin <[email protected]> > >--- > > src/fw/shadow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/src/fw/shadow.c b/src/fw/shadow.c > >index bdb5c5b..dcf1137 100644 > >--- a/src/fw/shadow.c > >+++ b/src/fw/shadow.c > >@@ -25,7 +25,7 @@ > > static void > > __make_bios_writable_intel(u16 bdf, u32 pam0) > > { > >- // Make ram from 0xc0000-0xf0000 writable > >+ // Make ram from 0xc0000-0xf0000 writable/readable > > int clear = 0; > > int i; > > for (i=0; i<6; i++) { > >@@ -45,7 +45,7 @@ __make_bios_writable_intel(u16 bdf, u32 pam0) > > if (clear) > > memset((void*)BUILD_BIOS_TMP_ADDR, 0, 32*1024); > > > >- // Make ram from 0xf0000-0x100000 writable > >+ // Make ram from 0xf0000-0xfffff writable > > int reg = pci_config_readb(bdf, pam0); > > pci_config_writeb(bdf, pam0, 0x30); > > if (reg & 0x10) > > > > -- > Yours Sincerely, > > Cao jin > > _______________________________________________ SeaBIOS mailing list [email protected] http://www.seabios.org/mailman/listinfo/seabios
