On 07/08/2016 07:57, Michael S. Tsirkin wrote: > On Fri, Aug 05, 2016 at 12:47:27PM +0200, Igor Mammedov wrote: >> MPTable doesn't support more than 255 CPUs and >> QEMU supplies an alternative MADT table which >> guest will use instead of it. So do not install >> legacy tables if more than 254 CPUs are provided >> >> Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > Acked-by: Michael S. Tsirkin <m...@redhat.com> > > In fact, should we disable these when loading > acpi from guest?
Old guests (and guests with no ACPI support) still require these tables. I think RHEL3 (which has a 2.4.x kernel) was one. Paolo > >> --- >> src/fw/paravirt.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/fw/paravirt.c b/src/fw/paravirt.c >> index 73a08f0..33a471b 100644 >> --- a/src/fw/paravirt.c >> +++ b/src/fw/paravirt.c >> @@ -164,8 +164,10 @@ qemu_platform_setup(void) >> smp_setup(); >> >> // Create bios tables >> - pirtable_setup(); >> - mptable_setup(); >> + if (MaxCountCPUs <= 255) { >> + pirtable_setup(); >> + mptable_setup(); >> + } >> smbios_setup(); >> >> if (CONFIG_FW_ROMFILE_LOAD) { >> -- >> 2.7.4 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://www.coreboot.org/mailman/listinfo/seabios