On Thu, Jun 13, 2019 at 04:25:53PM +0100, David Woodhouse wrote:
> Signed-off-by: David Woodhouse <dw...@infradead.org>
> ---
>  scripts/buildversion.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/buildversion.py b/scripts/buildversion.py
> index 8875497..fc2decd 100755
> --- a/scripts/buildversion.py
> +++ b/scripts/buildversion.py
> @@ -113,7 +113,9 @@ def main():
>  
>      cleanbuild, toolstr = tool_versions(options.tools)
>  
> -    ver = git_version()
> +    ver = os.getenv('SEABIOS_VERSION')
> +    if not ver:
> +        ver = git_version()
>      cleanbuild = cleanbuild and 'dirty' not in ver
>      if not ver:
>          ver = file_version()

Can you give some background on how this is intended to be used?

We used to allow the version string to be overridden, but we found the
results were a bit chaotic - different people chose different names
and it was hard to correlate a bug report to the source of the code.
So, we changed to the scheme detailed at:

https://www.seabios.org/Build_overview#Distribution_builds

Cheers,
-Kevin
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to