On Thu, Oct 17, 2019 at 09:44:38AM +0200, Uwe Kleine-König wrote: > On 10/16/19 12:27 PM, Gerd Hoffmann wrote: > > On Sat, Oct 12, 2019 at 10:07:23PM -0400, Kevin O'Connor wrote: > >> On Thu, Oct 10, 2019 at 05:43:30PM +0200, Uwe Kleine-König wrote: > >>> On 7/31/19 5:51 PM, Uwe Kleine-König wrote: > >>>> Hello, > >>>> > >>>> this is my attempt to address the review comments I got for v2: > >>>> > >>>> - Gerd pointed out that cbvesa should only use the modes where memmodel > >>>> == MM_DIRECT. > >>>> > >>>> - Kevin noted that reading global variables need the GET_GLOBAL > >>>> wrapper. (I would have expected that the compiler does the right > >>>> thing here. Probably I'm still to wet behind the ears here :-) > >>>> > >>>> Note this is only compile tested. > >>> > >>> Is there anything I have to do here to get these patches merged? > >> > >> The patches look fine to me. The commits should have a signed-off-by > >> line though. Gerd - do you have any further comments on this? > > > > No comments, looks all fine to me. > > Would it help if I prepared a pull-request for my patches? How else can > I help getting these patches in? I'm still unclear about that > Signed-of-by concern.
Re-send patches with Signed-of-by added to the commit message. Git can do that automatically for you (-s switch for "git commit"). It's used to keep track of the patch workflow (who wrote the patch, who reviewed & committed, ...). cheers, Gerd _______________________________________________ SeaBIOS mailing list -- seabios@seabios.org To unsubscribe send an email to seabios-le...@seabios.org
