Hi,

On Thu, Apr 8, 2021 at 12:28 PM Gerd Hoffmann <kra...@redhat.com> wrote:
>
>   Hi,
>
> > > -#define VBE_DISPI_MAX_XRES               2560
> > > -#define VBE_DISPI_MAX_YRES               1600
> > > +#define VBE_DISPI_MAX_XRES               3840
> > > +#define VBE_DISPI_MAX_YRES               2160
>
> > > +    { 0x199, { MM_DIRECT, 3840, 2160, 32, 8, 16, SEG_GRAPH } },
>
> > I'm not sure about this change.  Is 3840x2160 a standard of some kind?
>
> It is standard 4k (a comment saying that would be nice).

I'll update the commit.

>
> > Gerd - do you have any comments on this?
>
> The edid spec also has 4096x2160 and 5120x2160, should we add those too
> while being at it?  Not sure which ones are actually used in practice
> by monitors ...

These resolutions are used by ultra wide monitors.
I don't mind adding them, although I don't have a monitor that
supports these resolutions natively for testing.

>
> Also: What about depths other than 32?  I think we can safely ignore 24,
> nothing modern uses that since at least a decade, so it should not be
> relevant at all for 4k.  16bpp might be useful though.

I think we can add 24 for consistency. Every other resolution in the
table has all three modes.

Vitaly
_______________________________________________
SeaBIOS mailing list -- seabios@seabios.org
To unsubscribe send an email to seabios-le...@seabios.org

Reply via email to